netdev - Re: [PATCH net] macvlan: allow to enqueue broadcast pkt on virtual device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1411170271.26859.67.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 19 Sep 2014 16:44:31 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	David Miller <davem@...emloft.net>, nicolas.dichtel@...nd.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net] macvlan: allow to enqueue broadcast pkt on virtual
 device

On Sat, 2014-09-20 at 07:31 +0800, Herbert Xu wrote:

> While it would be nice to maintain the ability to chnge this
> parameter, I'm fine with this patch as it stands since it fixes
> a real regression.
> 
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

Another interesting feature would be to be able to time limit the queue,
and/or use a head drop instead of tail drop.

(ie timestamp skb when its enqueued into bc_queue,
 and at dequeue time, drop it if elapsed time is above a configurable
limit)

Processing a broadcast one minute after it was really sent makes little
sense, especially if we drop new incoming broadcasts because bc_queue is
full.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html