netdev - [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Sep 2014 16:50:59 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	linux-scsi <linux-scsi@...r.kernel.org>
CC:	James Bottomley <jbottomley@...allels.com>,
	Anish Bhatt <anish@...lsio.com>
Subject: [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC_ATTRS

From: Randy Dunlap <rdunlap@...radead.org>

Fix kconfig dependency warnings which can lead to build errors:

warning: (SCSI_BNX2X_FCOE && LIBFCOE && TCM_QLA2XXX) selects LIBFC which has unmet direct dependencies (SCSI_LOWLEVEL && SCSI && SCSI_FC_ATTRS)

warning: (FCOE && FCOE_FNIC) selects LIBFCOE which has unmet direct dependencies (SCSI_LOWLEVEL && SCSI && SCSI_FC_ATTRS)

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
---
 drivers/scsi/Kconfig         |    3 +++
 drivers/scsi/qla2xxx/Kconfig |    2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

--- linux-next-20140918.orig/drivers/scsi/Kconfig
+++ linux-next-20140918/drivers/scsi/Kconfig
@@ -601,6 +601,7 @@ config LIBFC
 
 config LIBFCOE
 	tristate "LibFCoE module"
+	depends on SCSI_FC_ATTRS
 	select LIBFC
 	---help---
 	  Library for Fibre Channel over Ethernet module
@@ -608,6 +609,7 @@ config LIBFCOE
 config FCOE
 	tristate "FCoE module"
 	depends on PCI
+	depends on SCSI_FC_ATTRS
 	select LIBFCOE
 	---help---
 	  Fibre Channel over Ethernet module
@@ -615,6 +617,7 @@ config FCOE
 config FCOE_FNIC
 	tristate "Cisco FNIC Driver"
 	depends on PCI && X86
+	depends on SCSI_FC_ATTRS
 	select LIBFCOE
 	help
 	  This is support for the Cisco PCI-Express FCoE HBA.
--- linux-next-20140918.orig/drivers/scsi/qla2xxx/Kconfig
+++ linux-next-20140918/drivers/scsi/qla2xxx/Kconfig
@@ -30,7 +30,7 @@ config SCSI_QLA_FC
 
 config TCM_QLA2XXX
 	tristate "TCM_QLA2XXX fabric module for Qlogic 2xxx series target mode HBAs"
-	depends on SCSI_QLA_FC && TARGET_CORE
+	depends on SCSI_QLA_FC && TARGET_CORE && SCSI_FC_ATTRS
 	select LIBFC
 	select BTREE
 	default n
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html