netdev - Re: [PATCH v7 ethtool 2/2] ethtool: Support for configurable RSS hash key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1411339090.20019.28.camel@decadent.org.uk>
Date:	Sun, 21 Sep 2014 23:38:10 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Venkat Duvvuru <VenkatKumar.Duvvuru@...lex.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v7 ethtool 2/2] ethtool: Support for configurable RSS
 hash key

On Sun, 2014-09-21 at 23:15 +0100, Ben Hutchings wrote:
> On Sun, 2014-09-21 at 21:52 +0100, Ben Hutchings wrote:
> > On Tue, 2014-07-22 at 17:51 +0530, Venkat Duvvuru wrote:
> > > This ethtool patch will primarily implement the parser for the options provided
> > > by the user for get and set rxfh before invoking the ioctl.
> > > This patch also has
> > > 1. Ethtool man page changes which describes the Usage of
> > >    get and set rxfh options.
> > > 2. Test cases for get and set rxfh in test-cmdline.c
> > > 
> > > Signed-off-by: Venkat Duvvuru <VenkatKumar.Duvvuru@...lex.com>
> > [...]
> > 
> > FAIL: test-cmdline
> > ==================
> > 
> > E: ethtool --rxfh devname hkey foo returns 0
> > E: ethtool -X devname hkey foo returns 0
> > 
> > The problem with these test cases is we can't parse the hash key (and
> > reject "foo") until after we start sending ioctls.  test-cmdline doesn't
> > include any mocking of ioctls, but instead makes each test successful if
> > it calls an ioctl.
> 
> It also doesn't work for me with an older kernel version (I tested on
> Linux 3.14).  I don't know why that is, as your fallback code does look
> reasonable.

Oops, I tested the previous version of this on 3.14.  The latest version
does work correctly.

I'll apply your changes and then disable the two failing test cases for
now.  Thanks for persisting with this.

Ben.

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert Camus

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)