netdev - [PATCH ethtool] test-cmdline: Disable test cases for --rxfh hash key parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1411339944.20019.30.camel@decadent.org.uk>
Date:	Sun, 21 Sep 2014 23:52:24 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	netdev@...r.kernel.org
Cc:	Venkat Duvvuru <VenkatKumar.Duvvuru@...lex.com>
Subject: [PATCH ethtool] test-cmdline: Disable test cases for --rxfh hash
 key parsing

test-cmdline does not mock the result of send_ioctl() but just treats
a call to send_ioctl() as indicating successful parsing.  Any parse
failure after this point cannot be tested for.  Currently, the hash
key string passed to --rxfh isn't parsed until after the device's key
size is known, so we can't test it tis way.

Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
---
 test-cmdline.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/test-cmdline.c b/test-cmdline.c
index be41a30..2fd7cbb 100644
--- a/test-cmdline.c
+++ b/test-cmdline.c
@@ -184,8 +184,14 @@ static struct test_case {
 	{ 0, "--set-rxfh-indir devname weight 1 2 3 4" },
 	{ 0, "--rxfh devname hkey 48:15:6e:bb:d8:bd:6f:b1:a4:c6:7a:c4:76:1c:29:98:da:e1:ae:6c:2e:12:2f:c0:b9:be:61:3d:00:54:35:9e:09:05:c7:d7:93:72:4a:ee" },
 	{ 0, "-X devname hkey 48:15:6e:bb:d8:bd:6f:b1:a4:c6:7a:c4:76:1c:29:98:da:e1:ae:6c:2e:12:2f:c0:b9:be:61:3d:00:54:35:9e:09:05:c7:d7:93:72:4a:ee" },
+#if 0
+	/* XXX These won't fail as expected because we don't parse the
+	 * hash key until after the first send_ioctl().  That needs to
+	 * be changed before we enable them.
+	 */
 	{ 1, "--rxfh devname hkey foo" },
 	{ 1, "-X devname hkey foo" },
+#endif
 	{ 0, "--rxfh devname hkey 48:15:6e:bb:d8:bd:6f:b1:a4:c6:7a:c4:76:1c:29:98:da:e1:ae:6c:2e:12:2f:c0:b9:be:61:3d:00:54:35:9e:09:05:c7:d7:93:72:4a:ee weight 1 2 3 4" },
 	{ 0, "-X devname weight 1 2 3 4 hkey 48:15:6e:bb:d8:bd:6f:b1:a4:c6:7a:c4:76:1c:29:98:da:e1:ae:6c:2e:12:2f:c0:b9:be:61:3d:00:54:35:9e:09:05:c7:d7:93:72:4a:ee" },
 	{ 0, "--rxfh devname hkey 48:15:6e:bb:d8:bd:6f:b1:a4:c6:7a:c4:76:1c:29:98:da:e1:ae:6c:2e:12:2f:c0:b9:be:61:3d:00:54:35:9e:09:05:c7:d7:93:72:4a:ee equal 2" },

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert Camus

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)