netdev - Re: [PATCH v2 net] ipv4: do not use this_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1411416706.26859.144.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 22 Sep 2014 13:11:46 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Joe M <joe9mail@...il.com>
Cc:	Tom Herbert <therbert@...gle.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net] ipv4: do not use this_cpu_ptr() in preemptible
 context

On Mon, 2014-09-22 at 14:34 -0500, Joe M wrote:
> p --ignore-case --exclude-dir=".git" --recursive this_cpu_ptr *.c
> ip_input.c:             struct ip_rt_acct *st = this_cpu_ptr(ip_rt_acct);
> ip_vti.c:       tstats = this_cpu_ptr(dev->tstats);
> route.c:                p = (struct rtable **)__this_cpu_ptr(nh->nh_pcpu_rth_output);
> route.c:                        prth = __this_cpu_ptr(nh->nh_pcpu_rth_output);
> tcp.c:          return __this_cpu_ptr(p);
> 
> Is it ok for ip_vti.c and ip_input.c to use this_cpu_ptr?

It is ok.

We run with BH disabled in these contexts.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html