netdev - Re: [PATCH net-next v2] fec: Staticize fec_enet_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140922.161656.2073239522143660859.davem@davemloft.net>
Date:	Mon, 22 Sep 2014 16:16:56 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	fabio.estevam@...escale.com
Cc:	Frank.Li@...escale.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] fec: Staticize fec_enet_select_queue()

From: Fabio Estevam <fabio.estevam@...escale.com>
Date: Fri, 19 Sep 2014 14:59:34 -0300

> fec_enet_select_queue() is only used locally, so mark it as 'static' to fix the
> following sparse warning:
> 
> drivers/net/ethernet/freescale/fec_main.c:2707:5: warning: symbol 'fec_enet_select_queue' was not declared. Should it be static?
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
> ---
> Changes since v1:
> - Make checkpatch happy

Please just delete this function.

It's overriding code which does exactly the same thing.

Actually, more precisely, this code is duplicating code in a way that
bypasses many core facilitites of the networking.  For example, this
override means that socket based flow steering, XPS, etc. are all
not happening on these devices.

Without ->ndo_select_queue(), the flow dissector does __netdev_pick_tx
which is exactly what you want to happen.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html