netdev - Re: [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140922.114913.1747319060949253295.davem@davemloft.net>
Date:	Mon, 22 Sep 2014 11:49:13 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	hch@...radead.org
Cc:	rdunlap@...radead.org, netdev@...r.kernel.org,
	linux-scsi@...r.kernel.org, jbottomley@...allels.com,
	anish@...lsio.com
Subject: Re: [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC_ATTRS

From: Christoph Hellwig <hch@...radead.org>
Date: Mon, 22 Sep 2014 07:42:13 -0700

> On Fri, Sep 19, 2014 at 04:50:59PM -0700, Randy Dunlap wrote:
>> --- linux-next-20140918.orig/drivers/scsi/qla2xxx/Kconfig
>> +++ linux-next-20140918/drivers/scsi/qla2xxx/Kconfig
>> @@ -30,7 +30,7 @@ config SCSI_QLA_FC
>>  
>>  config TCM_QLA2XXX
>>  	tristate "TCM_QLA2XXX fabric module for Qlogic 2xxx series target mode HBAs"
>> -	depends on SCSI_QLA_FC && TARGET_CORE
>> +	depends on SCSI_QLA_FC && TARGET_CORE && SCSI_FC_ATTRS
> 
> CONFIG_SCSI_QLA_FC currently selects SCSI_FC_ATTRS, so we shouldn't
> need this here. Also any reason not to switch that one over to a
> depends as well?
> 

Yes, all selects of SCSI_FC_ATTRS have to be changed to a depends.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html