netdev - Re: [RFC PATCH 00/24] TRILL implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140924205752.GC14754@electric-eye.fr.zoreil.com>
Date:	Wed, 24 Sep 2014 22:57:52 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	William Dauchy <william@...di.net>
Cc:	Stephen Hemminger <stephen@...workplumber.org>,
	Ahmed Amamou <ahmed@...di.net>, netdev@...r.kernel.org,
	f.cachereul@...halink.fr
Subject: Re: [RFC PATCH 00/24] TRILL implementation

William Dauchy <william@...di.net> :
> On Sep24 09:44, Stephen Hemminger wrote:
[...]
> > Also, it seems when you build with trill you lose normal bridge functionality.
> > Whether kernel is doing bridge or rbridge has to be a runtime (not compile time)
> > choice on a per-bridge basis.
> 
> The normal bridge functionnality are still ok until TRILL is not
> enabled.

Imvho you should remove patch #24 and plug directly into br_handle_frame.
It is not fair for usual bridge interfaces to become second class
citizens - rbr_handle_frame _is_ unbalanced - as soon as CONFIG_TRILL is
set and they are not TRILL enabled.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html