netdev - Re: [RFC PATCH 05/24] net: rbridge: Adapt Bridge structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140924205644.GB14754@electric-eye.fr.zoreil.com>
Date:	Wed, 24 Sep 2014 22:56:44 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Ahmed Amamou <ahmed@...di.net>
Cc:	netdev@...r.kernel.org, william@...di.net,
	f.cachereul@...halink.fr, Kamel Haddadou <kamel@...di.net>
Subject: Re: [RFC PATCH 05/24] net: rbridge: Adapt Bridge structure

Ahmed Amamou <ahmed@...di.net> :
[...]
> diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
> index 9c5529d..09dc18c 100644
> --- a/include/linux/etherdevice.h
> +++ b/include/linux/etherdevice.h
[...]
> @@ -391,4 +401,28 @@ static inline unsigned long compare_ether_header(const void *a, const void *b)
>  #endif
>  }
>  
> +#ifdef CONFIG_TRILL
> +/**
> + * is_all_rbr_address - check if it is a specific Rbridge brodcast mac address
> + * @addr1: Pointer to a six-byte array containing the Ethernet address
> + *
> + * returns true if it is a RBridge brodcast address 01:80:C2:00:00:40
> + */
> +static inline bool is_all_rbr_address(const u8 * addr1)
> +{
> +	return ether_addr_equal(addr1, eth_reserved_addr_all_rbridge);
> +}
> +
> +static inline bool is_isis_rbr_address(const u8 * addr1)
> +{
> +	return ether_addr_equal(addr1, eth_reserved_addr_isis_rbridge);
> +}
> +
> +static inline bool is_esadi_rbr_address(const u8 * addr1)
> +{
> +	return ether_addr_equal(addr1, eth_reserved_addr_esadi_rbridge);
> +}

Nit: s/addr1/addr (there's no addr2).

Neither is_isis_rbr_address nor is_esadi_rbr_address is ever used. They
could be added later.

You may consider merging the hunk above with patch #15.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html