netdev - Re: [RFC PATCH 15/24] net: rbridge: Add basic trill frame handling function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140924192354.GA14754@electric-eye.fr.zoreil.com>
Date:	Wed, 24 Sep 2014 21:23:54 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Ahmed Amamou <ahmed@...di.net>
Cc:	netdev@...r.kernel.org, william@...di.net,
	f.cachereul@...halink.fr, Kamel Haddadou <kamel@...di.net>
Subject: Re: [RFC PATCH 15/24] net: rbridge: Add basic trill frame handling
 function

Ahmed Amamou <ahmed@...di.net> :
[...]
> diff --git a/net/bridge/rbridge/rbr.c b/net/bridge/rbridge/rbr.c
> index edd1e7c..4b41d4c 100644
> --- a/net/bridge/rbridge/rbr.c
> +++ b/net/bridge/rbridge/rbr.c
> @@ -129,3 +129,103 @@ static void rbr_del_all(struct rbr *rbr)
[...]
> +	/* if trill is not enabled, handle by bridge */
> +	if (br->trill_enabled == BR_NO_TRILL) {
> +		goto handle_by_bridge;
> +	} else {

No need for an 'else' branch after a 'goto'. Please save an indent level.

Same remark apply in patches #19 and and #21 (almost: 'else' before 'goto').

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html