lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Sep 2014 15:57:29 -0700 From: John Fastabend <john.fastabend@...il.com> To: John Fastabend <john.r.fastabend@...el.com> CC: Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org, davem@...emloft.net Subject: Re: [Patch net-next 1/2] net_sched: fix errno in tcindex_set_parms() On 09/25/2014 02:07 PM, John Fastabend wrote: > On 09/25/2014 12:06 PM, Cong Wang wrote: >> When kmemdup() fails, we should return -ENOMEM. >> >> Cc: John Fastabend <john.fastabend@...il.com> >> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com> >> --- > > Acked-by: John Fastabend <john.r.fastabend@...el.com> > > Thanks Cong. > Related to this we should probably push error messages from the dump routines correctly. If you see u32_dump() returns a -EINVAL even though it was due to a memory allocation failure. This is not necessarily due to my patches though I think the error returning from dump has always been a simple -1 value. I'll take a look at it, unless you beat me to it, after I finish up the percpu stats which I'm doing now. .John -- John Fastabend Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists