lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Sep 2014 14:18:15 -0700 From: John Fastabend <john.r.fastabend@...el.com> To: Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org CC: davem@...emloft.net, John Fastabend <john.fastabend@...il.com> Subject: Re: [Patch net-next 2/2] net_sched: fix another regression in cls_tcindex On 09/25/2014 12:06 PM, Cong Wang wrote: > Clearly the following change is not expected: > > - if (!cp.perfect && !cp.h) > - cp.alloc_hash = cp.hash; > + if (!cp->perfect && cp->h) > + cp->alloc_hash = cp->hash; > > Fixes: commit 331b72922c5f58d48fd ("net: sched: RCU cls_tcindex") > Cc: John Fastabend <john.fastabend@...il.com> > Signed-off-by: Cong Wang <xiyou.wangcong@...il.com> > --- > net/sched/cls_tcindex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c > index 9d78fd7..a18eb1b 100644 > --- a/net/sched/cls_tcindex.c > +++ b/net/sched/cls_tcindex.c > @@ -303,7 +303,7 @@ tcindex_set_parms(struct net *net, struct tcf_proto *tp, unsigned long base, > cp->hash = DEFAULT_HASH_SIZE; > } > > - if (!cp->perfect && cp->h) > + if (!cp->perfect && !cp->h) > cp->alloc_hash = cp->hash; > > /* Note: this could be as restrictive as if (handle & ~(mask >> shift)) > Dang thanks. I added a test to my scripts that doesn't set the hash explicitly with TCA_TCINDEX_HASH. It looks like changes to the filter after the initial setup could fail without this fix. Acked-by: John Fastabend <john.r.fastabend@...el.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists