netdev - Re: [PATCH net] ematch: Fix matching of inverted containers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7N8-4LwaOqv8NHQ=p5-wU6ya9ya3GLsOkkBjQmhBQ94yA@mail.gmail.com>
Date:	Thu, 25 Sep 2014 14:08:24 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Ignacy Gawędzki 
	<ignacy.gawedzki@...en-communications.fr>,
	netdev <netdev@...r.kernel.org>
Cc:	Thomas Graf <tgraf@...g.ch>
Subject: Re: [PATCH net] ematch: Fix matching of inverted containers.

(Cc'ing Thomas)

On Wed, Sep 24, 2014 at 9:38 AM, Ignacy Gawędzki
<ignacy.gawedzki@...en-communications.fr> wrote:
> Negated expressions and sub-expressions need to have their flags checked for
> TCF_EM_INVERT and their result negated accordingly.
>
> Signed-off-by: Ignacy Gawędzki <ignacy.gawedzki@...en-communications.fr>
> ---
>  net/sched/ematch.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/net/sched/ematch.c b/net/sched/ematch.c
> index 3a633de..ad57f44 100644
> --- a/net/sched/ematch.c
> +++ b/net/sched/ematch.c
> @@ -526,9 +526,11 @@ pop_stack:
>                 match_idx = stack[--stackp];
>                 cur_match = tcf_em_get_match(tree, match_idx);
>
> -               if (tcf_em_early_end(cur_match, res))
> +               if (tcf_em_early_end(cur_match, res)) {
> +                       if (tcf_em_is_inverted(cur_match))
> +                               res = !res;
>                         goto pop_stack;
> -               else {
> +               } else {
>                         match_idx++;
>                         goto proceed;
>                 }
> --
> 1.9.1
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html