netdev - Re: [Patch net-next 1/2] net_sched: fix errno in tcindex_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Sep 2014 14:07:54 -0700
From:	John Fastabend <john.r.fastabend@...el.com>
To:	Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
CC:	davem@...emloft.net, John Fastabend <john.fastabend@...il.com>
Subject: Re: [Patch net-next 1/2] net_sched: fix errno in tcindex_set_parms()

On 09/25/2014 12:06 PM, Cong Wang wrote:
> When kmemdup() fails, we should return -ENOMEM.
> 
> Cc: John Fastabend <john.fastabend@...il.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> ---

Acked-by: John Fastabend <john.r.fastabend@...el.com>

Thanks Cong.

>  net/sched/cls_tcindex.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c
> index 5054fae..9d78fd7 100644
> --- a/net/sched/cls_tcindex.c
> +++ b/net/sched/cls_tcindex.c
> @@ -237,15 +237,14 @@ tcindex_set_parms(struct net *net, struct tcf_proto *tp, unsigned long base,
>  	if (err < 0)
>  		return err;
>  
> +	err = -ENOMEM;
>  	/* tcindex_data attributes must look atomic to classifier/lookup so
>  	 * allocate new tcindex data and RCU assign it onto root. Keeping
>  	 * perfect hash and hash pointers from old data.
>  	 */
>  	cp = kzalloc(sizeof(*cp), GFP_KERNEL);
> -	if (!cp) {
> -		err = -ENOMEM;
> +	if (!cp)
>  		goto errout;
> -	}
>  
>  	cp->mask = p->mask;
>  	cp->shift = p->shift;
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html