netdev - Re: [PATCH net-next 1/5] udp: Generalize skb_udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQJgoW1SbkK6hoJcRtTwyKxgNBtFYqBF-5aW9D4=Zi5ofg@mail.gmail.com>
Date:	Fri, 26 Sep 2014 12:39:50 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Tom Herbert <therbert@...gle.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/5] udp: Generalize skb_udp_segment

On Fri, Sep 26, 2014 at 9:22 AM, Tom Herbert <therbert@...gle.com> wrote:
> skb_udp_segment is the function called from udp4_ufo_fragment to
> segment a UDP tunnel packet. This function currently assumes
> segmentation is transparent Ethernet bridging (i.e. VXLAN
> encapsulation). This patch generalizes the function to
> operate on either Ethertype or IP protocol.

this is great generalization.
Do you envision that type_ether will cover vlan and mpls, right?
What if somebody crazy adds a new thing after udp encap
that is neither ethernet nor ip header?
Like encryption header?
I think it would fit this model well...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html