netdev - Re: [PATCH net-next] net: introduce __skb_header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140926.154021.663234155981881132.davem@davemloft.net>
Date:	Fri, 26 Sep 2014 15:40:21 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: introduce __skb_header_release()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 22 Sep 2014 16:29:32 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> While profiling TCP stack, I noticed one useless atomic operation
> in tcp_sendmsg(), caused by skb_header_release().
> 
> It turns out all current skb_header_release() users have a fresh skb,
> that no other user can see, so we can avoid one atomic operation.
> 
> Introduce __skb_header_release() to clearly document this.
> 
> This gave me a 1.5 % improvement on TCP_RR workload.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Looks great, applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html