netdev - Re: [PATCH net-next] tcp: abort orphan sockets stalling on zero window probes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140926.155611.954320324745536887.davem@davemloft.net>
Date:	Fri, 26 Sep 2014 15:56:11 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ycheng@...gle.com
Cc:	edumazet@...gle.com, andrey.dmitrov@...etlabs.ru,
	ncardwell@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: abort orphan sockets stalling on zero
 window probes

From: Yuchung Cheng <ycheng@...gle.com>
Date: Mon, 22 Sep 2014 20:52:13 -0700

> -
> +		if (!alive && icsk->icsk_backoff >= max_probes)
> +			goto abort;
>  		if (tcp_out_of_resources(sk, alive || icsk->icsk_probes_out <= max_probes))
>  			return;

This new logic means that the second argument to tcp_out_of_resources()
will always be 'true'.

Please make that explicit, because the code is confusing otherwise.

Also perhaps target this for the 'net' tree?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html