netdev - Re: [PATCH net-next] tcp: abort orphan sockets stalling on zero window probes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK6E8=ee8=hjQrYZNAKgs2YkCGEMSfzrLpu_Mr5joo987Y6M8Q@mail.gmail.com>
Date:	Mon, 29 Sep 2014 12:17:52 -0700
From:	Yuchung Cheng <ycheng@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	Eric Dumazet <edumazet@...gle.com>,
	Andrey Dmitrov <andrey.dmitrov@...etlabs.ru>,
	Neal Cardwell <ncardwell@...gle.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] tcp: abort orphan sockets stalling on zero
 window probes

On Fri, Sep 26, 2014 at 12:56 PM, David Miller <davem@...emloft.net> wrote:
> From: Yuchung Cheng <ycheng@...gle.com>
> Date: Mon, 22 Sep 2014 20:52:13 -0700
>
>> -
>> +             if (!alive && icsk->icsk_backoff >= max_probes)
>> +                     goto abort;
>>               if (tcp_out_of_resources(sk, alive || icsk->icsk_probes_out <= max_probes))
>>                       return;
>
> This new logic means that the second argument to tcp_out_of_resources()
> will always be 'true'.
>
> Please make that explicit, because the code is confusing otherwise.
>
> Also perhaps target this for the 'net' tree?
Sure I'll clear up the patch.

Net-next is probably a better target b/c it's more of a feature patch.
It also changes TCP_USER_TIMEOUT semantics slightly.

Thanks!

>
> Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html