netdev - Re: [PATCH net] net/mlx4_core: Allow not to specify probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140926.164715.648150882985516578.davem@davemloft.net>
Date:	Fri, 26 Sep 2014 16:47:15 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ogerlitz@...lanox.com
Cc:	netdev@...r.kernel.org, amirv@...lanox.com,
	jackm@....mellanox.co.il, matanb@...lanox.com
Subject: Re: [PATCH net] net/mlx4_core: Allow not to specify probe_vf in
 SRIOV IB mode

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Tue, 23 Sep 2014 16:05:59 +0300

> From: Matan Barak <matanb@...lanox.com>
> 
> When the HCA is configured in SRIOV IB mode (that is, at least one of
> the ports is IB) and the probe_vf module param isn't specified,
> mlx4_init_one() failed because of the following condition:
> 
> if (ib_ports && (num_vfs_argc > 1 || probe_vfs_argc > 1)) {
> 	 .....
> }
> 
> The root cause for that is a mistake in the initialization of num_vfs_argc
> and probe_vfs_argc. When num_vfs / probe_vf aren't given, their argument
> count counterpart should be 0, fix that.
> 
> Fixes: dd41cc3bb90e ('net/mlx4: Adapt num_vfs/probed_vf params for single port VF')
> Signed-off-by: Matan Barak <matanb@...lanox.com>
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>

Applied.

> This bug was introduced in 3.16, can you please push this patch along 
> with commit a91c772fa0275 "net/mlx4: Correctly configure single ported 
> VFs from the host" to 3.16-stable

Both patches queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html