netdev - Re: [PATCH] net: bcmgenet: Fix compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140926.165017.232526414533040628.davem@davemloft.net>
Date:	Fri, 26 Sep 2014 16:50:17 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tklauser@...tanz.ch
Cc:	f.fainelli@...il.com, geert@...ux-m68k.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: bcmgenet: Fix compile warning

From: Tobias Klauser <tklauser@...tanz.ch>
Date: Tue, 23 Sep 2014 15:19:41 +0200

> bcmgenet_wol_resume() is only used in bcmgenet_resume(), which is only
> defined when CONFIG_PM_SLEEP is enabled. This leads to the following
> compile warning when building with !CONFIG_PM_SLEEP:
> 
> drivers/net/ethernet/broadcom/genet/bcmgenet.c:1967:12: warning: ‘bcmgenet_wol_resume’ defined but not used [-Wunused-function]
> 
> Since bcmgenet_resume() is the only user of bcmgenet_wol_resume(), fix
> this by directly inlining the function there.
> 
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>

Applied to net-next, thanks.