netdev - Re: [PATCH v2 net-next 0/9] ipv6: fib6: socket dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 28 Sep 2014 01:32:02 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com,
	hideaki@...hifuji.org, vyasevich@...il.com,
	nicolas.dichtel@...nd.com, kafai@...com
Subject: Re: [PATCH v2 net-next 0/9] ipv6: fib6: socket dst_entry improvments and
 cleanups

On Fri, Sep 26, 2014, at 18:46, David Miller wrote:
> From: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Date: Fri, 26 Sep 2014 09:58:43 +0200
> 
> > On Fri, Sep 26, 2014, at 06:28, David Miller wrote:
> >> From: Hannes Frederic Sowa <hannes@...essinduktion.org>
> >> Date: Sun, 21 Sep 2014 16:11:44 +0200
> >> 
> >> > Eric Dumazet noticed that rt6_nodes wich are neither RTF_NONEXTHOP nor
> >> > RTF_GATEWAY but DST_HOST ones cause major routing lookup churn because
> >> > their rt6_genid is never renewed, thus ip6_dst_check always considers
> >> > them outdated. This is a major problem, because these kind of routes
> >> > are normally used to in input handling.
> >> 
> >> This series is a disappointment for me from the perspective of the
> >> fact that we have a regression in mainline and this is too complex
> >> of a set of changes for there.
> >> 
> >> If we relookup the thing every TCP input packet, we might as well
> >> not do the input route caching in the socket.
> > 
> > I can understand.
> > 
> > Toss this series, I'll try to do better tomorrow and send changes for
> > net and submit net-next cleanups when your queue is a bit smaller.
> 
> BTW, don't get me wrong, I like the new code and for 'net-next' it's
> good.

I didn't. ;)

> But for 'net' we have to come up with something simpler meanwhile.

Sure, I just posted one small patch to address the problem, cleanups and
smaller performance optimizations come in later after you did a merge.

Thanks,
Hannes
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html