lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 28 Sep 2014 01:44:27 +0200
From:	Hannes Frederic Sowa <>
To:	Eric Dumazet <>,
	Or Gerlitz <>
Cc:	Alexei Starovoitov <>,
	"David S. Miller" <>,
	Jesper Dangaard Brouer <>,
	Eric Dumazet <>,
	John Fastabend <>,
	Linux Netdev List <>,
	Amir Vadai <>,
	Or Gerlitz <>
Subject: Re: [PATCH net-next] mlx4: optimize xmit path

Hi Eric,

On Sun, Sep 28, 2014, at 00:56, Eric Dumazet wrote:
> -       ring->cons += txbbs_skipped;
> +
> +       /* we want to dirty this cache line once */
> +       ACCESS_ONCE(ring->last_nr_txbb) = last_nr_txbb;
> +       ACCESS_ONCE(ring->cons) = ring_cons + txbbs_skipped;
> +

Impressive work!

I wonder if another macro might be useful for those kind of
dereferences, because ACCESS_ONCE is associated with correctness in my
mind and those usages only try to optimize access patterns.
Does OPTIMIZER_HIDE_VAR generate the same code?

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists