lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 28 Sep 2014 14:48:18 -0400 From: Jamal Hadi Salim <jhs@...atatu.com> To: John Fastabend <john.fastabend@...il.com>, Cong Wang <xiyou.wangcong@...il.com> CC: John Fastabend <john.r.fastabend@...el.com>, netdev <netdev@...r.kernel.org> Subject: Re: tc rsvp filter show broke On 09/28/14 13:50, John Fastabend wrote: > On 09/28/2014 10:15 AM, Cong Wang wrote: > act->type = exts->type = TCA_OLD_COMPAT; > list_add(&act->list, &exts->actions); > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > Right. Note, this exts->xx thing we should eventually kill. It was intended to allow for old binary compatibility (for about 10 years now). In the earlier days, policer was a speacial action and one could invoke it directly from "tc filter ....." But over time, the more sane way is: "tc filter .. action police ..." We have killed ability to compile in the kernel policer to support to allow old tools to continue to use it at least 5 years ago. tc still has support but I doubt if anyone uses it. Otherwise there would have been a lot of fallout from commit 4bfb21ca2043dc5251102e4debcc0ae27f7304e7 in iproute2. So if there are any takers for patches, i think the first thing is to kill every call in iproute2 which calls police directly. And if nobody whines, then get rid of most of exts->XXX (at minimal there would be no need for exts->police) cheers, jamal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists