netdev - Re: [PATCH] hostap: proc: Remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140930165626.GD11919@tuxdriver.com>
Date:	Tue, 30 Sep 2014 12:56:26 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Jouni Malinen <j@...fi>, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, linaro-kernel@...ts.linaro.org
Subject: Re: [PATCH] hostap: proc: Remove unused variable

On Tue, Sep 16, 2014 at 04:16:55PM -0700, Mark Brown wrote:
> Since "hostap: proc: substitute loops by %*phN" (62c5afb8e388) the
> variable i has been unused in prism2_bss_list_proc_show() so remove it.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>  drivers/net/wireless/hostap/hostap_proc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/hostap/hostap_proc.c b/drivers/net/wireless/hostap/hostap_proc.c
> index 3a23a6d..dd84557 100644
> --- a/drivers/net/wireless/hostap/hostap_proc.c
> +++ b/drivers/net/wireless/hostap/hostap_proc.c
> @@ -168,7 +168,6 @@ static int prism2_bss_list_proc_show(struct seq_file *m, void *v)
>  	local_info_t *local = m->private;
>  	struct list_head *ptr = v;
>  	struct hostap_bss_info *bss;
> -	int i;
>  
>  	if (ptr == &local->bss_list) {
>  		seq_printf(m, "#BSSID\tlast_update\tcount\tcapab_info\tSSID(txt)\t"
> -- 
> 2.1.0

What tree are you using?  In wireless-next, I still see a loop in
that function using i as an index variable.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html