netdev - Re: [PATCH net-next] netfilter: bridge: build br_nf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140930.141001.265442216668830904.davem@davemloft.net>
Date:	Tue, 30 Sep 2014 14:10:01 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	pablo@...filter.org
Cc:	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
	eric.dumazet@...il.com, therbert@...gle.com, fw@...len.de
Subject: Re: [PATCH net-next] netfilter: bridge: build br_nf_core only if
 required

From: Pablo Neira Ayuso <pablo@...filter.org>
Date: Tue, 30 Sep 2014 10:59:18 +0200

> From: Florian Westphal <fw@...len.de>
> 
> Eric reports build failure with
> CONFIG_BRIDGE_NETFILTER=n
> 
> We insist to build br_nf_core.o unconditionally, but we must only do so
> if br_netfilter was enabled, else it fails to build due to
> functions being defined to empty stubs (and some structure members
> being defined out).
> 
> Also, BRIDGE_NETFILTER=y|m makes no sense when BRIDGE=n.
> 
> Fixes: 34666d467 (netfilter: bridge: move br_netfilter out of the core)
> Reported-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Florian Westphal <fw@...len.de>
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html