netdev - Re: [PATCH net-next 2/4] net/mlx5_core: Use hardware registers description header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140930.161357.778280234084349300.davem@davemloft.net>
Date:	Tue, 30 Sep 2014 16:13:57 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eli@...lanox.com
Cc:	alexei.starovoitov@...il.com, eli@....mellanox.co.il,
	netdev@...r.kernel.org, ogerlitz@...lanox.com,
	yevgenyp@...lanox.com
Subject: Re: [PATCH net-next 2/4] net/mlx5_core: Use hardware registers
 description header file

From: Eli Cohen <eli@...lanox.com>
Date: Tue, 30 Sep 2014 19:34:40 +0000

>> I find hard time believing that all of 4k auto generated macros are actually used. Could you trim it down to only usable bits?
> 
> 4K is the size of a header file that defines structs that describe the
> driver/firmware interface. It does not contribute a bit to code size.
> It's an autogenerated file based on data from the reference manual and
> I see no point in trimming it.

People will try to review it only to discover that it's completely unused.

I've been through this before with other device driver teams telling us
that it's part of some automated framework etc. and that doesn't make
it acceptable.

Please trim these things down to exactly what the driver uses.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html