[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20140930.161424.679705969149272577.davem@davemloft.net>
Date: Tue, 30 Sep 2014 16:14:24 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: eric.dumazet@...il.com
Cc: Yuval.Mintz@...gic.com, therbert@...gle.com, netdev@...r.kernel.org
Subject: Re: How exactly does CHECKSUM_COMPLETE works?
From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 30 Sep 2014 12:37:12 -0700
> On Tue, 2014-09-30 at 12:22 -0700, Eric Dumazet wrote:
>> On Tue, 2014-09-30 at 19:05 +0000, Yuval Mintz wrote:
>>
>> > Can you pinpoint me to what exactly in the code corrects NAPI_GRO_CB(skb)->csum
>> > by negating the ipv4 part in the ones' complete checksum?
>> >
>> > E.g., for ipv6 [in ipv6_gro_receive()] I can see that skb_gro_postpull_rcsum() is
>> > called after pulling the ipv6 header [and before proceeding to the next protocol],
>> > but I can't seem to find anything similar to this for ipv4 [in inet_gro_receive()].
>> >
>>
>>
>> IPv4 header is supposed to have a 0 checksum ;)
>>
>
> Or if you prefer :
Someone please submit this formally :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists