netdev - RE: [PATCH v2 1/1] net: fec: implement rx_copybreak to improve rx performance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <90749a3ae924458ab350f83d8b71c247@BLUPR03MB373.namprd03.prod.outlook.com>
Date:	Tue, 30 Sep 2014 01:38:29 +0000
From:	"fugang.duan@...escale.com" <fugang.duan@...escale.com>
To:	Zhi Li <lznuaa@...il.com>
CC:	Eric Dumazet <eric.dumazet@...il.com>,
	"Frank.Li@...escale.com" <Frank.Li@...escale.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"romieu@...zoreil.com" <romieu@...zoreil.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"shawn.guo@...aro.org" <shawn.guo@...aro.org>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>
Subject: RE: [PATCH v2 1/1] net: fec: implement rx_copybreak to improve rx
 performance

From: Zhi Li <lznuaa@...il.com> Sent: Monday, September 29, 2014 9:10 PM
>To: Duan Fugang-B38611
>Cc: Eric Dumazet; Li Frank-B20596; davem@...emloft.net;
>romieu@...zoreil.com; netdev@...r.kernel.org; shawn.guo@...aro.org;
>bhutchings@...arflare.com
>Subject: Re: [PATCH v2 1/1] net: fec: implement rx_copybreak to improve rx
>performance
>
>On Mon, Sep 29, 2014 at 7:43 AM, fugang.duan@...escale.com
><fugang.duan@...escale.com> wrote:
>> From: Eric Dumazet <eric.dumazet@...il.com> Sent: Monday, September
>> 29, 2014 8:12 PM
>>>To: Duan Fugang-B38611
>>>Cc: Li Frank-B20596; davem@...emloft.net; romieu@...zoreil.com;
>>>netdev@...r.kernel.org; shawn.guo@...aro.org;
>>>bhutchings@...arflare.com
>>>Subject: Re: [PATCH v2 1/1] net: fec: implement rx_copybreak to
>>>improve rx performance
>>>
>>>On Mon, 2014-09-29 at 15:47 +0800, Fugang Duan wrote:
>>>> - Copy short frames and keep the buffers mapped, re-allocate skb
>>>> instead
>>>of
>>>>   memory copy for long frames.
>>>> - Add support for setting/getting rx_copybreak using generic ethtool
>>>> tunable
>>>>
>>>> Changes V2:
>>>> * Implements rx_copybreak
>>>
>>>>
>>>> +#define COPYBREAK_DEFAULT 256
>>>> +static unsigned int copybreak __read_mostly = COPYBREAK_DEFAULT;
>>>> +module_param(copybreak, uint, 0644); MODULE_PARM_DESC(copybreak,
>>>> +             "Maximum packet size that is copied to a new buffer on
>>>receive");
>>>> +
>>>
>>>It is not the right way to handle this.
>>>
>>>Old drivers might still have a legacy module parameter.
>>>
>>>New implementations should provide the new ethtool support, and only
>this.
>>>No new module parameter is accepted.
>>>
>>>For details, check following commits :
>>>
>>>d4ad30b182305ecf97f145a5d4d1fd9e728c6d01 enic: Add tunable_ops support
>>>for rx_copybreak
>>>
>>>f0db9b073415848709dd59a6394969882f517da9 ethtool: Add generic options
>>>for tunables
>>>
>>>
>>>Or check the current tree :
>>>
>>>git grep -n rx_copybreak drivers/net/ethernet/cisco/enic
>>>
>> The patch implement ethtool interface, pls read the patch completely.
>
>I think Eric's means is that REMOVE module parameter and just keep ethtool
>API.
>
>best regards
>Frank Li
>
Ok, I will submit the next version to remove the module parameter.

Regards,
Andy