netdev - Re: [PATCH net-next] et131x: Add PCIe gigabit ethernet driver et131x to drivers/net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1412171027.3247.6.camel@joe-AO725>
Date:	Wed, 01 Oct 2014 06:43:47 -0700
From:	Joe Perches <joe@...ches.com>
To:	Tobias Klauser <tklauser@...tanz.ch>
Cc:	Mark Einon <mark.einon@...il.com>, davem@...emloft.net,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] et131x: Add PCIe gigabit ethernet driver
 et131x to drivers/net

On Wed, 2014-10-01 at 14:45 +0200, Tobias Klauser wrote:
> On 2014-09-30 at 23:29:46 +0200, Mark Einon <mark.einon@...il.com> wrote:
> > This adds the ethernet driver for Agere et131x devices to
> > drivers/net/ethernet.
[]
> > diff --git a/drivers/net/ethernet/agere/et131x.c b/drivers/net/ethernet/agere/et131x.c
[]
> > +	rc = pci_enable_device(pdev);
> > +	if (rc < 0) {
> > +		dev_err(&pdev->dev, "pci_enable_device() failed\n");
> > +		goto out;
> 
> Nit: Just return rc here.

I don't think it matters at all.

It's a predictable style to use common exit blocks.

It's a maintainer's right to do it in whatever
fashion is desired.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html