netdev - Re: [PATCH 33/34] netfilter: nf_tables: store and dump set policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOkSjBi59RdovSXCPMYHF8crscKFYOmK9i8Fpt2kLGvOJfT_gA@mail.gmail.com>
Date:	Wed, 1 Oct 2014 15:47:16 +0200
From:	Arturo Borrero Gonzalez <arturo.borrero.glez@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Pablo Neira Ayuso <pablo@...filter.org>,
	Netfilter Development Mailing list 
	<netfilter-devel@...r.kernel.org>, davem@...emloft.net,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 33/34] netfilter: nf_tables: store and dump set policy

On 29 September 2014 18:14, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
>>
>> index a476b99..19e79f0 100644
>> --- a/net/netfilter/nf_tables_api.c
>> +++ b/net/netfilter/nf_tables_api.c
>> @@ -2344,6 +2344,11 @@ static int nf_tables_fill_set(struct sk_buff *skb,
>> const struct nft_ctx *ctx,
>>                         goto nla_put_failure;
>>         }
>>
>> +       if (set->policy != NFT_SET_POL_PERFORMANCE) {
>> +               if (nla_put_be32(skb, NFTA_SET_POLICY,
>> htonl(set->policy)))
>> +                       goto nla_put_failure;
>
>
>    Why not fold these two *if* stetement into a single one?
>

I don't have any preference.

Should I send a patch to change it?

regards.
-- 
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html