| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 07 Oct 2014 13:21:02 -0400 (EDT) From: David Miller <davem@...emloft.net> To: amirv@...lanox.com, amirv.mellanox@...il.com Cc: eric.dumazet@...il.com, edumazet@...gle.com, netdev@...r.kernel.org, yevgenyp@...lanox.com, ogerlitz@...lanox.com, idos@...lanox.com Subject: Re: [PATCH net-next] net/mlx4_en: remove NETDEV_TX_BUSY From: Amir Vadai <amirv.mellanox@...il.com> Date: Tue, 07 Oct 2014 11:30:06 +0300 > On 10/6/2014 7:30 PM, Eric Dumazet wrote: >> From: Eric Dumazet <edumazet@...gle.com> >> >> Drivers should avoid NETDEV_TX_BUSY as much as possible. >> >> They should stop the tx queue before qdisc even tries to push another >> packet, to avoid requeues. >> >> For a driver supporting skb->xmit_more, this is likely to be a prereq >> anyway, otherwise we could have a tx deadlock : We need to force a >> doorbell if TX ring is full. >> >> Signed-off-by: Eric Dumazet <edumazet@...gle.com> >> --- > > Reviewed. Also verified that it fixes the deadlock (by sending a large > burst - larger than ring size). Before this fix, last packet of the > burst wasn't sent, therefore no doorbell was rang, and the queue was > stalled. > > BTW, another nice optimization that we hope to send soon, is not to arm > the CQ unless ringing the doorbell. > > Acked-by: Amir Vadai <amirv@...lanox.com> Applied, thanks everyone. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists