netdev - Re: [PATCH] net: fec: Fix sparse warnings with different lock contexts for basic block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5AhnRFUiCNBQ8FwdvjqVM+1fHfa3DUoHbqKTDcdg7AfBA@mail.gmail.com>
Date:	Sat, 11 Oct 2014 18:22:40 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Fugang Duan <b38611@...escale.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	sparse@...isli.org, Li Frank-B20596 <b20596@...escale.com>
Subject: Re: [PATCH] net: fec: Fix sparse warnings with different lock
 contexts for basic block

Hi Fugang,

On Sat, Oct 11, 2014 at 12:00 AM, Fugang Duan <b38611@...escale.com> wrote:
> reproduce:
> make  ARCH=arm C=1 2>fec.txt drivers/net/ethernet/freescale/fec_main.o
> cat fec.txt
>
> sparse warnings:
> drivers/net/ethernet/freescale/fec_main.c:2916:12: warning: context imbalance
> in 'fec_set_features' - different lock contexts for basic block
>
> Christopher Li suggest to change as below:
>         if (need_lock) {
>                 lock();
>                 do_something_real();
>                 unlock();
>         } else {
>                 do_something_real();
>         }
>
> Reported-by: Fabio Estevam <festevam@...il.com>
> Signed-off-by: Fugang Duan <B38611@...escale.com>
> Signed-off-by: Christopher Li <sparse@...isli.org>

It looks like Suggested-by is a more appropriate tag for Christopher.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html