netdev - RE: [PATCH] net: fec: Fix sparse warnings with different lock contexts for basic block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b0c14b7c6f1f46d58b69c5174b3766ae@BLUPR03MB373.namprd03.prod.outlook.com>
Date:	Mon, 13 Oct 2014 01:35:01 +0000
From:	"fugang.duan@...escale.com" <fugang.duan@...escale.com>
To:	Fabio Estevam <festevam@...il.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"sparse@...isli.org" <sparse@...isli.org>,
	"Frank.Li@...escale.com" <Frank.Li@...escale.com>
Subject: RE: [PATCH] net: fec: Fix sparse warnings with different lock
 contexts for basic block

From: Fabio Estevam <festevam@...il.com> Sent: Sunday, October 12, 2014 5:23 AM
>To: Duan Fugang-B38611
>Cc: David S. Miller; netdev@...r.kernel.org; sparse@...isli.org; Li Frank-
>B20596
>Subject: Re: [PATCH] net: fec: Fix sparse warnings with different lock
>contexts for basic block
>
>Hi Fugang,
>
>On Sat, Oct 11, 2014 at 12:00 AM, Fugang Duan <b38611@...escale.com> wrote:
>> reproduce:
>> make  ARCH=arm C=1 2>fec.txt drivers/net/ethernet/freescale/fec_main.o
>> cat fec.txt
>>
>> sparse warnings:
>> drivers/net/ethernet/freescale/fec_main.c:2916:12: warning: context
>> imbalance in 'fec_set_features' - different lock contexts for basic
>> block
>>
>> Christopher Li suggest to change as below:
>>         if (need_lock) {
>>                 lock();
>>                 do_something_real();
>>                 unlock();
>>         } else {
>>                 do_something_real();
>>         }
>>
>> Reported-by: Fabio Estevam <festevam@...il.com>
>> Signed-off-by: Fugang Duan <B38611@...escale.com>
>> Signed-off-by: Christopher Li <sparse@...isli.org>
>
>It looks like Suggested-by is a more appropriate tag for Christopher.

Agree, thanks. I will change it for V2.

Regards,
Andy