netdev - Re: [PATCH net] tcp: fix tcp_ack() performance problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141014.153059.1891014679903384495.davem@davemloft.net>
Date:	Tue, 14 Oct 2014 15:30:59 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, willemb@...gle.com, ncardwell@...gle.com,
	ycheng@...gle.com, vanj@...gle.com
Subject: Re: [PATCH net] tcp: fix tcp_ack() performance problem

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 11 Oct 2014 15:17:29 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> We worked hard to improve tcp_ack() performance, by not accessing
> skb_shinfo() in fast path (cd7d8498c9a5 tcp: change tcp_skb_pcount()
> location)
> 
> We still have one spurious access because of ACK timestamping,
> added in commit e1c8a607b281 ("net-timestamp: ACK timestamp for
> bytestreams")
> 
> By checking if sk_tsflags has SOF_TIMESTAMPING_TX_ACK set,
> we can avoid two cache line misses for the common case.
> 
> While we are at it, add two prefetchw() :
> 
> One in tcp_ack() to bring skb at the head of write queue.
> 
> One in tcp_clean_rtx_queue() loop to bring following skb,
> as we will delete skb from the write queue and dirty skb->next->prev.
> 
> Add a couple of [un]likely() clauses.
> 
> After this patch, tcp_ack() is no longer the most consuming
> function in tcp stack.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html