netdev - Re: [PATCH net] tcp: TCP Small Queues and strange attractors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141014.153308.2221538197341630790.davem@davemloft.net>
Date:	Tue, 14 Oct 2014 15:33:08 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp: TCP Small Queues and strange attractors

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 13 Oct 2014 06:27:47 -0700

> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index 8d4eac793700..4a7e97811d71 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -839,26 +839,38 @@ void tcp_wfree(struct sk_buff *skb)
>  {
 ...
>  		local_irq_restore(flags);
> -	} else {
> -		sock_wfree(skb);
> +		return;
>  	}
> +out:
> +	sk_free(sk);
>  }
>  

Why do we need to release the socket here?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html