netdev - Re: [net] i40e: _MASK vs _SHIFT typo in i40e_handle_mdd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1414034544.15751.2.camel@perches.com>
Date:	Wed, 22 Oct 2014 20:22:24 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, Dan Carpenter <dan.carpenter@...cle.com>,
	netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
	jogreene@...hat.com
Subject: Re: [net] i40e: _MASK vs _SHIFT typo in i40e_handle_mdd_event()

On Wed, 2014-10-22 at 20:06 -0700, Jeff Kirsher wrote:
> We accidentally mask by the _SHIFT variable.  It means that "event" is
> always zero.
[]
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
[]
> @@ -6151,7 +6151,7 @@ static void i40e_handle_mdd_event(struct i40e_pf *pf)
>  				I40E_GL_MDET_TX_PF_NUM_SHIFT;
>  		u8 vf_num = (reg & I40E_GL_MDET_TX_VF_NUM_MASK) >>
>  				I40E_GL_MDET_TX_VF_NUM_SHIFT;
> -		u8 event = (reg & I40E_GL_MDET_TX_EVENT_SHIFT) >>
> +		u8 event = (reg & I40E_GL_MDET_TX_EVENT_MASK) >>
>  				I40E_GL_MDET_TX_EVENT_SHIFT;
>  		u8 queue = (reg & I40E_GL_MDET_TX_QUEUE_MASK) >>
>  				I40E_GL_MDET_TX_QUEUE_SHIFT;
> @@ -6165,7 +6165,7 @@ static void i40e_handle_mdd_event(struct i40e_pf *pf)
>  	if (reg & I40E_GL_MDET_RX_VALID_MASK) {
>  		u8 func = (reg & I40E_GL_MDET_RX_FUNCTION_MASK) >>
>  				I40E_GL_MDET_RX_FUNCTION_SHIFT;
> -		u8 event = (reg & I40E_GL_MDET_RX_EVENT_SHIFT) >>
> +		u8 event = (reg & I40E_GL_MDET_RX_EVENT_MASK) >>
>  				I40E_GL_MDET_RX_EVENT_SHIFT;
>  		u8 queue = (reg & I40E_GL_MDET_RX_QUEUE_MASK) >>
>  				I40E_GL_MDET_RX_QUEUE_SHIFT;

It might be useful to have a macro for that.
Something like:

#define GET_REG_VAL(reg, type)			\
	((reg & type##_MASK) >> type##_SHIFT)

so these could become:

	u8 vf_num = GET_REG_VAL(reg, I40E_GL_MDET_TX_VF_NUM);
	u8 event = GET_REG_VAL(reg, I40E_GL_MDET_TX_EVENT);

etc...

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html