lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAKD1Yr13oLyBsbuh92F91Fjno3Xv4vBQ1B__8Csoi0XUjJv9nw@mail.gmail.com> Date: Tue, 28 Oct 2014 17:19:44 +0900 From: Lorenzo Colitti <lorenzo@...gle.com> To: Erik Kline <ek@...gle.com> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>, Ben Hutchings <ben@...adent.org.uk>, Hannes Frederic Sowa <hannes@...essinduktion.org> Subject: Re: [PATCH net-next] net: ipv6: Add a sysctl to make optimistic addresses useful candidates On Tue, Oct 28, 2014 at 4:42 PM, Erik Kline <ek@...gle.com> wrote: > * Configure the address for reception. Now it is valid. > */ > > - ipv6_ifa_notify(RTM_NEWADDR, ifp); > + /* If optimistic DAD is in use, the notification was already sent > + * in addrconf_dad_begin(). > + */ > + if (!ipv6_use_optimistic_addr(ifp->idev)) > + ipv6_ifa_notify(RTM_NEWADDR, ifp); Won't this result in not sending RTM_NEWADDR messages if use_optimistic is enabled on the interface, but the IP address that has just completed DAD is not an optimistic address (e.g., if it's a manually-configured address)? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists