lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAAedzxoKWVpu67vycM_b0O5bA7mpWP=PGvj_ENbZZEVFpoMGqw@mail.gmail.com> Date: Tue, 28 Oct 2014 17:59:06 +0900 From: Erik Kline <ek@...gle.com> To: Lorenzo Colitti <lorenzo@...gle.com> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>, Ben Hutchings <ben@...adent.org.uk>, Hannes Frederic Sowa <hannes@...essinduktion.org> Subject: Re: [PATCH net-next] net: ipv6: Add a sysctl to make optimistic addresses useful candidates >> * Configure the address for reception. Now it is valid. >> */ >> >> - ipv6_ifa_notify(RTM_NEWADDR, ifp); >> + /* If optimistic DAD is in use, the notification was already sent >> + * in addrconf_dad_begin(). >> + */ >> + if (!ipv6_use_optimistic_addr(ifp->idev)) >> + ipv6_ifa_notify(RTM_NEWADDR, ifp); > > Won't this result in not sending RTM_NEWADDR messages if > use_optimistic is enabled on the interface, but the IP address that > has just completed DAD is not an optimistic address (e.g., if it's a > manually-configured address)? Gah, yes. I originally unconditionally sent the RTM_NEWADDR, but there was some concern about sending duplicates so this was a weak attempt to reduce spurious messages. I still think sending the RTM_NEWADDR unconditionally is the right thing, since we send them all the time when something about the address changes (including timer-refresh on receipt of RAs). I'll revert that bit and send an updated patch ASAP. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists