lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Oct 2014 22:11:31 +0100 From: Andrew Lunn <andrew@...n.ch> To: Guenter Roeck <linux@...ck-us.net> Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Florian Fainelli <f.fainelli@...il.com>, Andrew Lunn <andrew@...n.ch>, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 09/15] net: dsa: Add support for switch EEPROM access > +static int dsa_slave_get_eeprom_len(struct net_device *dev) > +{ > + struct dsa_slave_priv *p = netdev_priv(dev); > + struct dsa_switch *ds = p->parent; > + > + if (ds->pd->eeprom_len) > + return ds->pd->eeprom_len; > + > + if (ds->drv->get_eeprom_len) > + return ds->drv->get_eeprom_len(ds); > + > + return 0; > +} > + Hi Guenter I just started doing some testing with this patchset. A bit late since David just accepted it, but... root@...665:~# ethtool -e lan4 Cannot get EEPROM data: Invalid argument root@...665:~# ethtool -e eth0 Cannot get EEPROM data: Operation not supported There is no eeprom for the hardware i'm testing. Operation not supported seems like a better error code and Invalid argument, and is what other network drivers i tried returned. Andrew -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists