netdev - Re: drivers: net: cpsw: Fix broken loop condition in switch mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 31 Oct 2014 16:17:12 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	lsorense@...lub.uwaterloo.ca
Cc:	linux-kernel@...r.kernel.org, hs@...x.de, mugunthanvnm@...com,
	netdev@...r.kernel.org
Subject: Re: drivers: net: cpsw: Fix broken loop condition in switch mode

From: "Lennart Sorensen" <lsorense@...lub.uwaterloo.ca>
Date: Fri, 31 Oct 2014 13:28:54 -0400

> 0d961b3b52f566f823070ce2366511a7f64b928c (drivers: net: cpsw: fix buggy
> loop condition) accidentally fixed a loop comparison in too many places
> while fixing a real bug.
> 
> It was correct to fix the dual_emac mode section since there 'i' is used
> as an index into priv->slaves which is a 0 based array.
> 
> However the other two changes (which are only used in switch mode)
> are wrong since there 'i' is actually the ALE port number, and port 0
> is the host port, while port 1 and up are the slave ports.
> 
> Putting the loop condition back in the switch mode section fixes it.
> 
> A comment has been added to point out the intent clearly to avoid future
> confusion.  Also a comment is fixed that said the opposite of what was
> actually happening.
> 
> Signed-off-by: Len Sorensen <lsorense@...lub.uwaterloo.ca>
> Acked-by: Heiko Schocher <hs@...x.de>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html