netdev - Re: [PATCH] smc91x: retrieve IRQ and trigger flags in a modern way

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141101.170439.601714821948738788.davem@davemloft.net>
Date:	Sat, 01 Nov 2014 17:04:39 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	linus.walleij@...aro.org
Cc:	netdev@...r.kernel.org, nico@...xnic.net
Subject: Re: [PATCH] smc91x: retrieve IRQ and trigger flags in a modern way

From: Linus Walleij <linus.walleij@...aro.org>
Date: Fri, 31 Oct 2014 21:32:06 +0100

> The SMC91x is written to explicitly look up the IRQ resource
> from the platform device and extract the IRQ and flags, however
> the platform_get_irq() does additional things, like call
> of_irq_get() in the device tree case, which will translate
> the IRQ using the irqdomain and defer the probe if the
> IRQ host cannot be found.
> 
> As we're not looking up the resource, this will not retrieve
> the IRQ flags, but that is better done using
> irqd_get_trigger_type(), as the trigger is what the driver
> wants to modify. We take care to preserve the semantics that
> will make the trigger type provided from the resource
> override any local specifier.
> 
> Tested on the Nomadik NHK15 which has its SMC91x IRQ line
> connected to a STMPE2401 GPIO expander on I2C.
> 
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html