netdev - Re: [PATCH net-next 3/7] gue: Add infrastructure for flags and options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141103.151248.1183539988304355806.davem@davemloft.net>
Date:	Mon, 03 Nov 2014 15:12:48 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/7] gue: Add infrastructure for flags and
 options

From: Tom Herbert <therbert@...gle.com>
Date: Mon, 3 Nov 2014 10:39:14 -0800

> On Mon, Nov 3, 2014 at 9:18 AM, David Miller <davem@...emloft.net> wrote:
>> From: Tom Herbert <therbert@...gle.com>
>> Date: Sat,  1 Nov 2014 15:57:59 -0700
>>
>>> @@ -20,7 +20,16 @@ static size_t fou_encap_hlen(struct ip_tunnel_encap *e)
>>>
>>>  static size_t gue_encap_hlen(struct ip_tunnel_encap *e)
>>>  {
>>> -     return sizeof(struct udphdr) + sizeof(struct guehdr);
>>> +     size_t len;
>>> +     bool need_priv = false;
>>> +
>>> +     len = sizeof(struct udphdr) + sizeof(struct guehdr);
>>> +
>>> +     /* Add in lengths flags */
>>> +
>>> +     len += need_priv ? GUE_LEN_PRIV : 0;
>>
>> Add this need_priv logic in patch #6, not here.
> 
> I would rather keep it in this patch. This is adding the common
> infrastructure to support private option field, remote checksum
> offload is an instance that uses that.

Tom, it evaluates always to a constant boolean, and contextually makes
no sense to someone reviewing this change in isolation.

Please, as I have asked, put this in the patch where the logic
actually matters.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html