netdev - Re: [PATCH] VNIC: Adding support for Cavium ThunderX network controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141103122525.22679b68@urahara>
Date:	Mon, 3 Nov 2014 12:25:25 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Robert Richter <robert.richter@...iumnetworks.com>
Cc:	Sunil Kovvuri <sunil.kovvuri@...il.com>,
	Robert Richter <rric@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Sunil Goutham <sgoutham@...ium.com>,
	Stefan Assmann <sassmann@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	LAKML <linux-arm-kernel@...ts.infradead.org>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH] VNIC: Adding support for Cavium ThunderX network
 controller

On Mon, 3 Nov 2014 19:33:45 +0100
Robert Richter <robert.richter@...iumnetworks.com> wrote:

> On 03.11.14 10:16:51, Stephen Hemminger wrote:
> > On Fri, 31 Oct 2014 22:44:11 +0530
> > Sunil Kovvuri <sunil.kovvuri@...il.com> wrote:
> > 
> > > On Fri, Oct 31, 2014 at 8:24 AM, Stephen Hemminger
> > > <stephen@...workplumber.org> wrote:
> > > > On Thu, 30 Oct 2014 17:54:34 +0100
> > > > Robert Richter <rric@...nel.org> wrote:
> > > >
> > > >> +#ifdef       VNIC_RSS_SUPPORT
> > > >> +static int rss_config = RSS_IP_HASH_ENA | RSS_TCP_HASH_ENA | RSS_UDP_HASH_ENA;
> > > >> +module_param(rss_config, int, S_IRUGO);
> > > >> +MODULE_PARM_DESC(rss_config,
> > > >> +              "RSS hash config [bits 8:0] (Bit0:L2 extended, 1:IP, 2:TCP, 3:TCP SYN, 4:UDP, 5:L4 extended, 6:ROCE 7:L3 bi-directional, 8:L4 bi-directional)");
> > > >> +#endif
> > > >
> > > > This should managed  be via ethtool ETHTOOL_GRXFH rather than a module parameter.
> > > Thanks, i will add setting hash options via ETHTOOL_SRXFH as well.
> > > The idea here is to have a choice of hash while module load (through
> > > module params) and if it needs to be changed runtime then
> > > via Ethtool.
> > > 
> > > Sunil.
> > 
> > Network developers do not like vendor unique module parameters.
> > Anything device specific doesn't work in a generic distro environment.
> 
> Do you accept unique module parameters in parallel to ethtool support
> or should this be removed?

If there is ethtool support the module parameters are not needed.
Unneeded code is to be avoided.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html