netdev - Re: [PATCH] net: phy: spi_ks8995: remove sysfs bin file by registered attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <545917BA.50800@gmail.com>
Date:	Tue, 04 Nov 2014 10:15:22 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Vladimir Zapolskiy <vz@...ia.com>, netdev@...r.kernel.org
CC:	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net: phy: spi_ks8995: remove sysfs bin file by registered
 attribute

On 11/03/2014 03:25 PM, Vladimir Zapolskiy wrote:
> When a sysfs binary file is asked to be removed, it is found by
> attribute name, so strictly speaking this change is not a fix, but
> just in case when attribute name is changed in the driver or sysfs
> internals are changed, it might be better to remove the previously
> created file using right the same binary attribute.
> 
> Signed-off-by: Vladimir Zapolskiy <vz@...ia.com>
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: David S. Miller <davem@...emloft.net>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

> ---
>  drivers/net/phy/spi_ks8995.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c
> index eab57fc..4653015 100644
> --- a/drivers/net/phy/spi_ks8995.c
> +++ b/drivers/net/phy/spi_ks8995.c
> @@ -353,7 +353,9 @@ static int ks8995_probe(struct spi_device *spi)
>  
>  static int ks8995_remove(struct spi_device *spi)
>  {
> -	sysfs_remove_bin_file(&spi->dev.kobj, &ks8995_registers_attr);
> +	struct ks8995_switch *ks = spi_get_drvdata(spi);
> +
> +	sysfs_remove_bin_file(&spi->dev.kobj, &ks->regs_attr);
>  
>  	return 0;
>  }
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html