netdev - Re: [PATCH 00/13] net_sched: misc cleanups and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1415125250.25370.2.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 04 Nov 2014 10:20:50 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	netdev@...r.kernel.org, Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH 00/13] net_sched: misc cleanups and improvements

On Tue, 2014-11-04 at 09:56 -0800, Cong Wang wrote:
> Minor code cleanups for TC qdiscs and filters, each patch has
> more details.
> 
> Cong Wang (13):
>       net_sched: refactor out tcf_exts
>       net_sched: introduce qdisc_peek() helper function
>       net_sched: rename ->gso_skb to ->dequeued_skb
>       net_sched: rename qdisc_drop() to qdisc_drop_skb()
>       net_sched: introduce qdisc_drop() helper function
>       net_sched: move some qdisc flag into qdisc ops
>       net_sched: move TCQ_F_MQROOT into qdisc ops
>       net_sched: use a flag to indicate fifo qdiscs instead of the name
>       net_sched: redefine qdisc_create_dflt()
>       net_sched: forbid setting default qdisc to inappropriate ones
>       net_sched: remove hashmask from Qdisc_class_hash
>       net_sched: remove useless qdisc_stab_lock
>       net_sched: return NULL instead of ERR_PTR for qdisc_alloc()
> 

NACK for the whole serie.

I am tired of your inexistent changelogs and code churn in qdisc.

If you do not care of writing good changelogs and explain why you want
all this, why should I care spending time to review all this stuff ?

What is the plan, beyond all this code churn ?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html