lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.DEB.2.02.1411061056540.24819@rocker1.rocker.net> Date: Thu, 6 Nov 2014 10:57:23 -0800 (PST) From: Scott Feldman <sfeldma@...il.com> To: Florian Fainelli <f.fainelli@...il.com> cc: Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org, davem@...emloft.net, nhorman@...driver.com, andy@...yhouse.net, tgraf@...g.ch, dborkman@...hat.com, ogerlitz@...lanox.com, jesse@...ira.com, pshelar@...ira.com, azhou@...ira.com, ben@...adent.org.uk, stephen@...workplumber.org, jeffrey.t.kirsher@...el.com, vyasevic@...hat.com, xiyou.wangcong@...il.com, john.r.fastabend@...el.com, edumazet@...gle.com, jhs@...atatu.com, sfeldma@...il.com, roopa@...ulusnetworks.com, linville@...driver.com, jasowang@...hat.com, ebiederm@...ssion.com, nicolas.dichtel@...nd.com, ryazanov.s.a@...il.com, buytenh@...tstofly.org, aviadr@...lanox.com, nbd@...nwrt.org, alexei.starovoitov@...il.com, Neil.Jerram@...aswitch.com, ronye@...lanox.com, simon.horman@...ronome.com, alexander.h.duyck@...hat.com, john.ronciak@...el.com, mleitner@...hat.com, shrijeet@...il.com, gospo@...ulusnetworks.com, bcrl@...ck.org Subject: Re: [patch net-next 07/10] bridge: call netdev_sw_port_stp_update when bridge port STP status changes On Thu, 6 Nov 2014, Florian Fainelli wrote: > On 11/06/2014 01:20 AM, Jiri Pirko wrote: >> From: Scott Feldman <sfeldma@...il.com> >> >> To notify switch driver of change in STP state of bridge port, add new >> .ndo op and provide swdev wrapper func to call ndo op. Use it in bridge >> code then. >> >> Signed-off-by: Scott Feldman <sfeldma@...il.com> >> Signed-off-by: Jiri Pirko <jiri@...nulli.us> >> --- > > [snip] > >> #endif /* _LINUX_SWITCHDEV_H_ */ >> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c >> index 86c239b..13fecf1 100644 >> --- a/net/bridge/br_netlink.c >> +++ b/net/bridge/br_netlink.c >> @@ -17,6 +17,7 @@ >> #include <net/net_namespace.h> >> #include <net/sock.h> >> #include <uapi/linux/if_bridge.h> >> +#include <net/switchdev.h> >> >> #include "br_private.h" >> #include "br_private_stp.h" >> @@ -304,6 +305,7 @@ static int br_set_port_state(struct net_bridge_port *p, u8 state) >> >> br_set_state(p, state); >> br_log_state(p); >> + netdev_sw_port_stp_update(p->dev, p->state); > > Is there a reason netdev_sw_port_stp_update() is not folded in > br_set_state()? Are we missing calls to br_set_state() in some locations? I put the netdev_sw call at the same level as br_log_state() and br_ifinfo_notify(), but now that you bring up the question, I agree it would be cleaner/safer if netdev_sw call was from br_set_state(). > -- > Florian > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists