netdev - Re: [patch net-next 05/10] rocker: introduce rocker switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 07 Nov 2014 15:08:25 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jiri@...nulli.us
Cc:	netdev@...r.kernel.org, nhorman@...driver.com, andy@...yhouse.net,
	tgraf@...g.ch, dborkman@...hat.com, ogerlitz@...lanox.com,
	jesse@...ira.com, pshelar@...ira.com, azhou@...ira.com,
	ben@...adent.org.uk, stephen@...workplumber.org,
	jeffrey.t.kirsher@...el.com, vyasevic@...hat.com,
	xiyou.wangcong@...il.com, john.r.fastabend@...el.com,
	edumazet@...gle.com, jhs@...atatu.com, sfeldma@...il.com,
	f.fainelli@...il.com, roopa@...ulusnetworks.com,
	linville@...driver.com, jasowang@...hat.com, ebiederm@...ssion.com,
	nicolas.dichtel@...nd.com, ryazanov.s.a@...il.com,
	buytenh@...tstofly.org, aviadr@...lanox.com, nbd@...nwrt.org,
	alexei.starovoitov@...il.com, Neil.Jerram@...aswitch.com,
	ronye@...lanox.com, simon.horman@...ronome.com,
	alexander.h.duyck@...hat.com, john.ronciak@...el.com,
	mleitner@...hat.com, shrijeet@...il.com, gospo@...ulusnetworks.com,
	bcrl@...ck.org
Subject: Re: [patch net-next 05/10] rocker: introduce rocker switch driver

From: Jiri Pirko <jiri@...nulli.us>
Date: Thu,  6 Nov 2014 10:20:05 +0100

> +#include <generated/utsrelease.h>

The version of this driver is not the version of the kernel, please do not
pretend that it is.

Define a proper DRV_MODULE_VERSION and MODULE_VERSION() like other drivers
do rather than using UTS_RELEASE or whatever.

> +static u32 rocker_msix_vector(struct rocker *rocker, unsigned vector)

Please do not use plain "unsigned", always say "unsigned int".

> +#ifdef CONFIG_NET_SWITCHDEV
> +	.ndo_sw_parent_id_get		= rocker_port_sw_parent_id_get,
> +#endif

Maybe better to just make the driver depend upon NET_SWITCHDEV?

> +struct rocker_desc {
> +	u64 buf_addr;
> +	u64 cookie;
> +	u16 buf_size;
> +	u16 tlv_size;
> +	u16 resv[5];
> +	u16 comp_err;
> +} __packed __aligned(8);

This __packed seems unnecessary, and __packed should always be avoided
when possible because it generates terrible code on some cpus.

> +/* Rocker DMA TLV struct */
> +struct rocker_tlv {
> +	u32 type;
> +	u16 len;
> +} __packed __aligned(8);

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html