netdev - Re: [PATCHv4 1/1] net: fec: fix regression on i.MX28 introduced by rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141107.120926.297493918093719160.davem@davemloft.net>
Date:	Fri, 07 Nov 2014 12:09:26 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	festevam@...il.com
Cc:	LW@...o-electronics.de, netdev@...r.kernel.org,
	fabio.estevam@...escale.com, Frank.Li@...escale.com,
	linux-kernel@...r.kernel.org, rmk+kernel@....linux.org.uk,
	linux-arm-kernel@...ts.infradead.org, stefan.wahren@...e.com
Subject: Re: [PATCHv4 1/1] net: fec: fix regression on i.MX28 introduced by
 rx_copybreak support

From: Fabio Estevam <festevam@...il.com>
Date: Fri, 7 Nov 2014 10:26:15 -0200

> On Fri, Nov 7, 2014 at 7:02 AM, Lothar Waßmann <LW@...o-electronics.de> wrote:
>> commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx performance")
>> introduced a regression for i.MX28. The swap_buffer() function doing
>> the endian conversion of the received data on i.MX28 may access memory
>> beyond the actual packet size in the DMA buffer. fec_enet_copybreak()
>> does not copy those bytes, so that the last bytes of a packet may be
>> filled with invalid data after swapping.
>> This will likely lead to checksum errors on received packets.
>> E.g. when trying to mount an NFS rootfs:
>> UDP: bad checksum. From 192.168.1.225:111 to 192.168.100.73:44662 ulen 36
>>
>> Do the byte swapping and copying to the new skb in one go if
>> necessary.
>>
>> Signed-off-by: Lothar Waßmann <LW@...O-electronics.de>
> 
> With this patch I am able to NFS mount on mx28 again. Thanks, Lothar!
> 
> Tested-by: Fabio Estevam <fabio.estevam@...escale.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html