netdev - Re: [PATCH v2] stmmac: remove custom implementation of print_hex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141107.122053.864393917282057137.davem@davemloft.net>
Date:	Fri, 07 Nov 2014 12:20:53 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	andriy.shevchenko@...ux.intel.com
Cc:	joe@...ches.com, peppe.cavallaro@...com, netdev@...r.kernel.org,
	vbridgers2013@...il.com
Subject: Re: [PATCH v2] stmmac: remove custom implementation of
 print_hex_dump()

From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Date: Fri,  7 Nov 2014 16:53:12 +0200

> There is a kernel helper to dump buffers in a hexdecimal format. This patch
> substitutes the open coded function by calling that helper.
> 
> The output is slightly changed:
>  - no lead space
>  - ASCII part will be printed along with the dump
>  - offset is longer than 3 characters (now 8)
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> Since v1:
> - address Joe's comments
> - describe output change
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 ++--------

Applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html