netdev - Re: [PATCH net-next] sky2: use new netdev_rss_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1416410886.14060.48.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 19 Nov 2014 07:28:06 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Ian Morris <ipm@...rality.org.uk>
Cc:	netdev@...r.kernel.org, Mirko Lindner <mlindner@...vell.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next] sky2: use new netdev_rss_key_fill() helper

On Wed, 2014-11-19 at 09:06 +0000, Ian Morris wrote:
> Switch to a random RSS key rather than a fixed one.
> Using netdev_rss_key_fill helper also ensures that all ports share
> a common key.
> 
> See also commit 960fb622f85180f36d3aff82af53e2be3db2f888.
> 
> Signed-off-by: Ian Morris <ipm@...rality.org.uk>
> Cc: Mirko Lindner <mlindner@...vell.com>
> Cc: Stephen Hemminger <stephen@...workplumber.org>
> Cc: Eric Dumazet <edumazet@...gle.com>
> ---
>  drivers/net/ethernet/marvell/sky2.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)

Nice catch, this one escaped from my scan ;)

(Another one is in drivers/net/ethernet/cisco/enic/enic_main.c )

Acked-by: Eric Dumazet <edumazet@...gle.com>

Nit : When referring a commit, use 12 digit sha1 followed by patch
title.
In this particular case you could have say :

See also commit 960fb622f851 ("net: provide a per host RSS key generic
infrastructure").

Or something like that.

Thanks Ian !



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html